fix: migrate from RoktStripePaymentExtension to unified RoktPaymentExtension#85
fix: migrate from RoktStripePaymentExtension to unified RoktPaymentExtension#85rmi22186 wants to merge 6 commits into
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Extension Migrate from per-provider payment extension (RoktStripePaymentExtension) to unified payment extension (RoktPaymentExtension) that supports all payment providers (Stripe, AfterPay, PayPal) in a single package. - Kits/RoktStripePayment → Kits/RoktPaymentExtension - @mparticle/cordova-rokt-stripe-payment-kit → @mparticle/cordova-rokt-payment-extension-kit - Pod: RoktStripePaymentExtension → RoktPaymentExtension - Update RoktPaymentSetup.swift bridging class - Update example config.xml, hook comment, and README Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RoktPaymentExtension 1.0.0 has been published to CocoaPods. Note: requires mParticle-Apple-SDK to update its RoktContracts dependency from ~> 0.1 to ~> 1.0 before pod resolution will succeed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR SummaryMedium Risk Overview This renames the plugin/package identifiers and updates iOS pod wiring in Reviewed by Cursor Bugbot for commit bde7829. Bugbot is set up for automated code reviews on this repo. Configure here. |
Drop the "-kit" suffix since the payment extension is a Rokt SDK extension, not an mParticle kit. Update package id, plugin id, config references, lockfile, and README snippet. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 13438a9. Configure here.
…sion Add `cordova plugin add` commands alongside the `config.xml` snippets so users can pick either install style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
closing as this is resolved in #93 now due to drift in versions since this PR was opened over a month ago. |
1 participant
Summary
Renames the payment extension plugin from
@mparticle/cordova-rokt-payment-extension-kitto@mparticle/cordova-rokt-payment-extension(drops-kitsince it's a Rokt SDK extension, not an mParticle kit) and updates the README to show bothcordova plugin addandconfig.xmlinstall styles. Code-complete but cannot be built end-to-end against published pods — see blockers below.Upstream blockers
mParticle-Apple-SDK— podspecs (umbrella,-ObjC,mParticle-Rokt) still declareRoktContracts ~> 0.1; must bump to~> 1.0and publish (9.0.2). CI failure demonstrates the resulting pod-resolution conflict againstRoktPaymentExtension 1.0+.Rokt-Widget 5.0.0—PaymentOrchestrator.swift:97callspresentPaymentSheet(...)without thecontext: PaymentContextparameter thatRoktContracts 1.0requires; needs a5.0.1with that call site updated. (Not visible in CI — only surfaces after blocker above is resolved.)